-
-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
State execution documentation #439
Draft
lukestanley
wants to merge
6
commits into
develop
Choose a base branch
from
state
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
…r quick and easy reference
gsambrotta
reviewed
Mar 7, 2024
}) | ||
export class BlocksWorkflowComponent implements OnInit { | ||
export class BlocksWorkflowComponent implements OnInit, OnChanges { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lukestanley what about trying DoCheck
too here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of the investigation of state reactivity problems #435, it's helpful to document exactly how our system works (#436).
I started commenting BlocksWorkflowComponent, and added "Compodoc" to help explore Angular component dependencies.
Given a simple Flow of a Mapping Block generating a random UUID, and a Debug Block, I uncommented the console.log's in the BlocksWorkflowComponent, and reviewed them to made this sequence diagram:
I'm not quite sure where to put this sort of thing yet, obviously we wouldn't want to loose it! It might end up along side the RST files that Read the Docs uses.
It's only part of my investigation and it's not easy to understand yet.